Move PaymentSheet String utils out of StripePaymentsUI#5970
Draft
davidme-stripe wants to merge 2 commits intodavidme/move-ps-imagesfrom
Draft
Move PaymentSheet String utils out of StripePaymentsUI#5970davidme-stripe wants to merge 2 commits intodavidme/move-ps-imagesfrom
davidme-stripe wants to merge 2 commits intodavidme/move-ps-imagesfrom
Conversation
davidme-stripe
force-pushed
the
davidme/move-ps-string-utils
branch
from
1715c42 to
391cc83
Compare
1 build increased size, 2 builds decreased size, 5 builds had no size change
StripeSize 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| Other | ⬆️ 1.8 kB |
| Packed Asset | ⬇️ 0 B |
| 🗑 StripePaymentsUI.STPStringUtils.sanitizedExpirationDateFromOCRStr... | ⬇️ -896 B |
| 🗑 StripePaymentsUI.STPStringUtils.stringMayContainExpirationDate | ⬇️ -592 B |
| Other | ⬇️ -2.2 kB |
View Treemap
StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize
No changes to report
StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 1.9 kB (-0.03%)
Total download size change: ⬇️ 2.5 kB (-0.13%)
Largest size changes
| Item | Install Size Change |
|---|---|
| Other | ⬆️ 1.8 kB |
| Packed Asset | ⬇️ 0 B |
| 🗑 StripePaymentsUI.STPStringUtils.sanitizedExpirationDateFromOCRStr... | ⬇️ -716 B |
| 🗑 StripePaymentsUI.STPStringUtils.stringMayContainExpirationDate | ⬇️ -580 B |
| Other | ⬇️ -2.3 kB |
View Treemap
StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 110.9 kB (0.9%)
Total download size change: ⬆️ 82.2 kB (1.92%)
Largest size changes
| Item | Install Size Change |
|---|---|
| Packed Asset | ⬆️ 0 B |
| Other | ⬆️ 9.8 kB |
| 🗑 StripePaymentSheet.STPStringUtils | ⬇️ -8.6 kB |
| 📝 icon-card-unionpay.svg (Vector) | ⬆️ 5.5 kB |
| 📝 StripePaymentSheet.PaymentSheetStringUtils.applyLinksToString(tem... | ⬆️ 3.1 kB |
View Treemap
StripeIdentitySize 1.0 (1)
com.stripe.StripeIdentitySize
No changes to report
StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize
No changes to report
StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize
No changes to report
StripeConnectSize 1.0 (1)
com.stripe.StripeConnectSize
No changes to report
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
|
🚨 New dead code detected in this PR: STPStringUtils.swift:207 warning: Unused property 'expirationDateStringRegex'
STPStringUtils.swift:214 warning: Unused function 'expirationDateString(from:)'
STPStringUtils.swift:244 warning: Unused property 'stringMayContainExpirationDateRegex'
STPStringUtils.swift:253 warning: Unused function 'stringMayContainExpirationDate(_:)'
STPStringUtils.swift:262 warning: Unused property 'slashFormattedExpirationDateRegex'
STPStringUtils.swift:269 warning: Unused function 'sanitizedExpirationDateFromOCRString(_:)'Please remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with [find-dead-code] |
Copies card brand and other payment-related images to StripePaymentSheet and creates PaymentSheetImageLibrary to replace STPImageLibrary usage.
Moves string utility functions from StripePaymentsUI to StripePaymentSheet.
davidme-stripe
force-pushed
the
davidme/move-ps-string-utils
branch
from
391cc83 to
4ec2b39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing
Changelog